Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61627655
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new
IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new
IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
I understand why we don't want to use FSIdempotentStorageManger in
FileSplitter as FileSplitter is more generic than FS. However I think setting
Noop disables idempotency by default. How about letting the user knowingly make
that choice by not creating it in the operator and set to @NotNull so the user
will have to set it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
