Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61659396
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new
IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new
IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
The reason to make this change is that if multiple
```FSIdempotentStorageManager```s are used in an application then their state
(on disk) collide. The jira APEXMALHAR-2068 is opened to address that.
The problem in having FSIdempotentStorageManager as default is that the
users get bewildered because of in-correct behavior manifested by the bug
mentioned above.
If the user sets FSIdempotentStorageManage explicitly then they can ensure
to make the relative path unique as well.
Not setting any default entails additional step of setting an Idempotent
storage manager even when the user doesn't care about idempotency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
