Hi Zhiyuan I think I agree with Justin, -1 binding, this release has license issue.
> Please take a look at LICENSE[1] file under Dashboard repository, we have > added the description for those files you just mentioned :) The release in the ASF is about the source release, so, the tar ball here[1] should include the accurate and right license file. The link you posted, https://github.com/apache/incubator-apisix-dashboard/blob/329b092dcaa7a505dcdec86c667b6803f5863d94/LICENSE#L205, is not a part of ASF release. [1] https://dist.apache.org/repos/dist/dev/incubator/apisix/1.3-rc1/ Sheng Wu 吴晟 Twitter, wusheng1108 Zhiyuan Ju <juzhiy...@apache.org> 于2020年5月13日周三 上午11:00写道： > Hi Justin, > > Please take a look at LICENSE[1] file under Dashboard repository, we have > added the description for those files you just mentioned :) > > [1] > > https://github.com/apache/incubator-apisix-dashboard/blob/329b092dcaa7a505dcdec86c667b6803f5863d94/LICENSE#L205 > > Best Regards! > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > > Justin Mclean <jus...@classsoftware.com> 于2020年5月13日周三 上午9:52写道： > > > Hi, > > > > Sorry but its -1 (binding) from me > > > > I checked: > > - incubating in name > > - DISCLAIMER is OK > > - LICENSE is missing licensing information > > - NOTICE is fine > > - No unexpected binary files > > - ASF file have ASF headers > > > > There is a 40 odd files with "Copyright (c) 2018 Chong Guo” in the > > dashboard which seems to be under a MIT license but this is not mentioned > > in the top level LICENSE file. > > > > Thanks, > > Justin >
