thanks Sheng, I got it. thanks for your help and detailed explanation. Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing
Sheng Wu <wu.sheng.841...@gmail.com> 于2020年5月13日周三 下午2:29写道： > Hi Ming and Zhiyuan > > This is a license issue, but not hard to fix. > The key issue is, as a release tar, the LICENSE file in the root folder is > the `primary` license. I know you have put the MIT license in the dashboard > folder, but you missed the pointer in the primary license. > Also at the same time, the LICENSE/NOTICE/DISCLAIMER files in the dashboard > folder are not really required. > > I think this is caused by the changes in your release process. Once you > merge the main repo and dashboard repo and make the decision that you > always release them together, the LICENSE/NOTICE files in the main repo / > root folder should be maintained only. > > Is this clear now? > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > Ming Wen <wenm...@apache.org> 于2020年5月13日周三 下午2:04写道： > > > Hi, Sheng, > > Thanks for your reminder. > > > > I'm a little confused. I see a lot of apache projects that have the > > `licenses` directory > > which hold the licenses of specific dependencies > > and are indexed in the LICENSE file in the root directory. > > > > The Apache APISIX 1.3 release includes the `licenses` directory > > and specific license files too. > > > > Waht should we do to solve the license problem? thanks. > > > > Thanks, > > Ming Wen, Apache APISIX & Apache SkyWalking > > Twitter: _WenMing > > > > > > Zhiyuan Ju <juzhiy...@apache.org> 于2020年5月13日周三 下午12:00写道： > > > > > Thanks for your reminder! > > > > > > So we should append the entire MIT LICENSE[1] content to the root > > LICENSE? > > > > > > [1] > > > > > > > > > https://github.com/apache/incubator-apisix-dashboard/blob/329b092dcaa7a505dcdec86c667b6803f5863d94/licenses/LICENSE.vue-typescript-admin-template > > > > > > Best Regards! > > > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > > > > > > > > Sheng Wu <wu.sheng.841...@gmail.com> 于2020年5月13日周三 上午11:53写道： > > > > > > > Hi Zhiyuan > > > > > > > > I think I agree with Justin, > > > > -1 binding, this release has license issue. > > > > > > > > > Please take a look at LICENSE[1] file under Dashboard repository, > we > > > have > > > > > added the description for those files you just mentioned :) > > > > The release in the ASF is about the source release, so, the tar ball > > > > here[1] should include the accurate and right license file. > > > > The link you posted, > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix-dashboard/blob/329b092dcaa7a505dcdec86c667b6803f5863d94/LICENSE#L205 > > > > , > > > > is not a part of ASF release. > > > > > > > > [1] https://dist.apache.org/repos/dist/dev/incubator/apisix/1.3-rc1/ > > > > > > > > Sheng Wu 吴晟 > > > > Twitter, wusheng1108 > > > > > > > > > > > > Zhiyuan Ju <juzhiy...@apache.org> 于2020年5月13日周三 上午11:00写道： > > > > > > > > > Hi Justin, > > > > > > > > > > Please take a look at LICENSE[1] file under Dashboard repository, > we > > > have > > > > > added the description for those files you just mentioned :) > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix-dashboard/blob/329b092dcaa7a505dcdec86c667b6803f5863d94/LICENSE#L205 > > > > > > > > > > Best Regards! > > > > > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > > > > > > > > > > > > > > Justin Mclean <jus...@classsoftware.com> 于2020年5月13日周三 上午9:52写道： > > > > > > > > > > > Hi, > > > > > > > > > > > > Sorry but its -1 (binding) from me > > > > > > > > > > > > I checked: > > > > > > - incubating in name > > > > > > - DISCLAIMER is OK > > > > > > - LICENSE is missing licensing information > > > > > > - NOTICE is fine > > > > > > - No unexpected binary files > > > > > > - ASF file have ASF headers > > > > > > > > > > > > There is a 40 odd files with "Copyright (c) 2018 Chong Guo” in > the > > > > > > dashboard which seems to be under a MIT license but this is not > > > > mentioned > > > > > > in the top level LICENSE file. > > > > > > > > > > > > Thanks, > > > > > > Justin > > > > > > > > > > > > > > >
