Hi Sheng, Justin,

Thanks for your response. I am trying to resolve the NOTICE and LICENSE
issue in PR[1].
In the source distribution package, removed all of the 3rd libraries'
licenses and added the license of `mvnw`.
After that, I removed logback which seems like under EPL and
other unnecessary dependencies.

[1] https://github.com/apache/apisix-java-plugin-runner/pull/45
-----------------------

Haochao Zhuang

Sheng Wu <wu.sheng.841...@gmail.com> 于2021年6月29日周二 上午9:57写道:

> OK, then continuously, I am confused about why we call 0.1.0 out in this
> status.
> In the Java ecosystem, this kind of loading mechanism is just an SPI, why
> don't we finish that before releasing it?
> A doc about importing a project is super strange guidance for Java
> developers.
>
> We should have the SPI mechanism, and release the dependencies on Maven
> Central. Docs should guide users to add maven dependencies only.
>
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Zexuan Luo <spacewan...@apache.org> 于2021年6月29日周二 上午9:54写道:
>
> > Hi,
> > the result of why we don't provide binary in the vote is that the 0.1
> > version of Java Runner hasn't supported loading user-defined plugins.
> >
> > Currently, the only way to add a plugin is to put your code inside
> > Java Runner and recompile it:
> >
> >
> https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/en/latest/development.md#code-location
> > .
> > We can add a binary package in the future, but provide a binary
> > package now is meaningless, as nobody can use it directly.
> >
> > Sheng Wu <wu.sheng.841...@gmail.com> 于2021年6月28日周一 下午10:44写道:
> > >
> > > Hi,
> > >
> > > I want to ask from a Java developer perspective, why there is no binary
> > in
> > > the vote?
> > > This seems not a common case in Java ecosystem.
> > >
> > > After the `mvn package`, from the voting perspective, I have to vote
> > > -1 binding
> > > LICENSE and NOTICE in apisix-runner-bin are both not correct.
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> > >
> > > Zexuan Luo <spacewan...@apache.org> 于2021年6月28日周一 下午3:02写道:
> > >
> > > > Hello, Community,
> > > > This is a call for the vote to release Apache APISIX Java Plugin
> > > > Runner version 0.1.
> > > >
> > > > Release notes:
> > > >
> > > >
> > > >
> >
> https://github.com/apache/apisix-java-plugin-runner/blob/release/0.1/CHANGELOG.md#010
> > > >
> > > > The release candidates:
> > > >
> > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-java-plugin-runner-0.1/
> > > >
> > > > Release Commit ID:
> > > >
> > > >
> > > >
> >
> https://github.com/apache/apisix-java-plugin-runner/commit/b8620260236fdd3756c9e4725a71dde4f6246d3b
> > > >
> > > > Keys to verify the Release Candidate:
> > > >
> > > > https://dist.apache.org/repos/dist/release/apisix/KEYS
> > > >
> > > > Steps to validating the release:
> > > >
> > > > 1. Download the release
> > > >
> > > > wget
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-java-plugin-runner-0.1/apisix-java-plugin-runner-0.1.0-src.tgz
> > > >
> > > > 2. Checksums and signatures
> > > >
> > > > wget https://dist.apache.org/repos/dist/release/apisix/KEYS
> > > >
> > > > wget
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-java-plugin-runner-0.1/apisix-java-plugin-runner-0.1.0-src.tgz.asc
> > > >
> > > > wget
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-java-plugin-runner-0.1/apisix-java-plugin-runner-0.1.0-src.tgz.sha512
> > > >
> > > > shasum -c apisix-java-plugin-runner-0.1.0-src.tgz.sha512
> > > >
> > > > gpg --verify apisix-java-plugin-runner-0.1.0-src.tgz.asc
> > > > apisix-java-plugin-runner-0.1.0-src.tgz
> > > >
> > > > 3. Unzip and Check files
> > > >
> > > > tar zxvf apisix-java-plugin-runner-0.1.0-src.tgz
> > > >
> > > > 4. Build & Test Apache APISIX Java Plugin Runner:
> > > >
> > > >
> > > >
> >
> https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/en/latest/development.md
> > > >
> > > > The vote will be open for at least 72 hours or until necessary number
> > of
> > > > votes are reached.
> > > >
> > > > Please vote accordingly:
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> >
>

Reply via email to