-1 (binding)

I checked:
1. 1.8's Download links are OK, but there are a lot of wrong 1.7 download
links there. (mitigable [1])
2. Checksum is OK
3. GPG Signature Verification Failure (immitigable [2])

    gpg: Signature made Wed 27 Dec 2023 01:13:36 PM UTC
    gpg:                using EDDSA key
F3B7F68C42145CA0B03FDC08732A2D86CF3A8CC9
    gpg: Can't check signature: No public key


4. Lots of errors when decompressing. Please don't expect all readers to
use macOS; use Linux for build release packages. (mitigable [1])

......
tar: Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.provenance'
./pkg/types/apisix/v1/
./pkg/types/apisix/v1/._types.go
tar: Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.provenance'
./pkg/types/apisix/v1/types.go
./pkg/types/apisix/v1/._doc.go
tar: Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.provenance'
./pkg/types/apisix/v1/doc.go
./pkg/types/apisix/v1/._plugin_types.go
......

5. LICENSE and NOTICE files exist.
6. Building on Gitpod (Ubuntu 22.04) was successful.

[1] mitigable: It has errors and should be when corrected, but it does not
affect the build.
[2] immitigable: Unacceptable errors that should be corrected.

I can re-vote when the critical error (GPG verification failed) is fixed.

Ashish Tiwari <ashishjaitiwari15112...@gmail.com> 于2023年12月27日周三 21:31写道:

> Hello, Community,
> This is a call for the vote to release Apache APISIX Ingress
> controller version 1.8.0
>
> Release notes:
>
>
> https://github.com/apache/apisix-ingress-controller/blob/v1.8.0/CHANGELOG.md#180
>
> The release candidates:
>
>
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.
> 0/
> <https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/>
> <
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.7.0/
> >
>
> Git tag for the release:
>
> https://github.com/apache/apisix-ingress-controller/tree/v1.8.0
> <https://github.com/apache/apisix-ingress-controller/tree/v1.7.0>
>
> Release Commit ID:
>
>
> https://github.com/apache/apisix-ingress-controller/commit/f0130c9fd9064c4de42d9cd0663ec4c4ab2ca8fa
>
> Keys to verify the Release Candidate:
>
> https://dist.apache.org/repos/dist/dev/apisix/KEYS
>
> Steps to validating the release:
>
> 1. Download the release
>
> wget
>
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.
> 0/apache-apisix-ingress-controller-1.8.0-src.tgz
> <https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz>
> <
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.7.0/apache-apisix-ingress-controller-1.7.0-src.tgz
> >
>
>
> 2. Checksums and signatures
>
> wget https://dist.apache.org/repos/dist/dev/apisix/KEYS
>
> wget
>
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.
> 0/apache-apisix-ingress-controller-1.8.0-src.tgz.asc
> <https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz.asc>
> <
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.7.0/apache-apisix-ingress-controller-1.7.0-src.tgz.asc
> >
>
> wget
>
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.
> 0/apache-apisix-ingress-controller-1.8.0-src.tgz.sha512
> <https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz.sha512>
> <
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.7.0/apache-apisix-ingress-controller-1.7.0-src.tgz.sha512
> >
>
> gpg --import KEYS
>
> shasum -c apache-apisix-ingress-controller-1.8.0-src.tgz.sha512
>
> gpg --verify apache-apisix-ingress-controller-1.8.0-src.tgz.asc
>  apache-apisix-ingress-controller-1.8.0-src.tgz
>
> 3. Unzip and Check files
>
> mkdir -p apisix-ingress-controller && tar
> zxvf apache-apisix-ingress-controller-1.8.0-src.tgz
> -C ./apisix-ingress-controller && cd apisix-ingress-controller
>
> 4. Build
>
> Please refer to
> https://apisix.apache.org/docs/ingress-controller/contribute/
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks!
>


-- 
Best regards!
Zeping Bai  @bzp2010

Reply via email to