+1 (binding) I checked： 1. Download links are OK. 2. Checksum and signature are OK. 3. LICENSE and NOTICE files exist. 4. Building on macOS(13.3.1) was successful.
Zhiyuan Ju <juzhiy...@apache.org> 于2024年1月18日周四 00:40写道： > Hi, > > +1 (binding) > > I have tried the following items: > > 1. Download links are OK. > > 2. Checksum and signature are OK. > > 3. LICENSE and NOTICE files exist. > > 4. No unnecessary files. > > I didn't try to build it, as my new environment doesn't have Golang > installed. > > > > On Fri, Jan 5, 2024 at 3:52 AM Zhiyuan Ju <juzhiy...@apache.org> wrote: > > > Hi, > > > > I provisioned a new Ubuntu instance and met the following error: > > > > root@ingress-1-components-docker-ubuntu-s-2vcpu-4gb-amd-sgp1-01 > :~/apisix-ingress-controller# > > make build > > CGO_ENABLED=0 go build \ > > -o apisix-ingress-controller \ > > -ldflags "-X=" > > github.com/apache/apisix-ingress-controller/pkg/version._buildVersion > "=1.8.0 > > -X=" > > > github.com/apache/apisix-ingress-controller/pkg/version._buildGitRevision > "="no-git-module" > > -X="github.com/apache/apisix-ingress-controller/pkg/version._buildOS > "=linux/amd64" > > \ > > main.go > > cmd/cmd.go:22:2: cannot find package > > cmd/cmd.go:23:2: cannot find package > > cmd/cmd.go:20:2: cannot find package > > make: *** [Makefile:64: build] Error 1 > > > > I suggest you can find more people to verify it. > > > > > > On Thu, Jan 4, 2024 at 1:28 PM Zeping Bai <bzp2...@apache.org> wrote: > > > >> +1 (binding) > >> > >> I checked： > >> 1. Download links are OK. > >> 2. Checksum and signature are OK. > >> 3. LICENSE and NOTICE files exist. > >> 4. Building on Gitpod (Ubuntu 22.04) was successful. > >> > >> Some macOS-related warnings remain, and it would be nice to be able to > >> compress code using Linux, which we can do next time. (I am using Ubuntu > >> now) > >> > >> ``` > >> ./cmd/._cmd.go > >> tar: Ignoring unknown extended header keyword > >> 'LIBARCHIVE.xattr.com.apple.provenance' > >> ./cmd/cmd.go > >> ./cmd/._ingress > >> tar: Ignoring unknown extended header keyword > >> 'LIBARCHIVE.xattr.com.apple.provenance' > >> ./cmd/ingress/ > >> ./cmd/ingress/._ingress.go > >> ``` > >> > >> > >> Ashish Tiwari <ashishjaitiwari15112...@gmail.com> 于2024年1月3日周三 16:11写道： > >> > >> > Hello, Community, > >> > This is a call for the vote to release Apache APISIX Ingress > >> > controller version 1.8.0. Few issues on the last voting mail have been > >> > corrected. > >> > > >> > Release notes: > >> > > >> > > >> > > >> > https://github.com/apache/apisix-ingress-controller/blob/v1.8.0/CHANGELOG.md#180 > >> > > >> > The release candidates: > >> > > >> > > >> > > >> > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/ > >> > > >> > > >> > Git tag for the release: > >> > > >> > https://github.com/apache/apisix-ingress-controller/tree/v1.8.0 > >> > > >> > Release Commit ID: > >> > > >> > > >> > > >> > https://github.com/apache/apisix-ingress-controller/commit/f0130c9fd9064c4de42d9cd0663ec4c4ab2ca8fa > >> > > >> > Keys to verify the Release Candidate: > >> > > >> > https://dist.apache.org/repos/dist/dev/apisix/KEYS > >> > > >> > Steps to validating the release: > >> > > >> > 1. Download the release > >> > > >> > wget > >> > > >> > > >> > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz > >> > > >> > > >> > 2. Checksums and signatures > >> > > >> > wget https://dist.apache.org/repos/dist/dev/apisix/KEYS > >> > > >> > > >> > wget > >> > > >> > > >> > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz.asc > >> > > >> > wget > >> > > >> > > >> > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.8.0/apache-apisix-ingress-controller-1.8.0-src.tgz.sha512 > >> > > >> > gpg --import KEYS > >> > > >> > shasum -c apache-apisix-ingress-controller-1.8.0-src.tgz.sha512 > >> > > >> > gpg --verify apache-apisix-ingress-controller-1.8.0-src.tgz.asc > >> > apache-apisix-ingress-controller-1.8.0-src.tgz > >> > > >> > > >> > 3. Unzip and Check files > >> > > >> > mkdir -p apisix-ingress-controller && tar > >> > zxvf apache-apisix-ingress-controller-1.8.0-src.tgz > >> > -C ./apisix-ingress-controller && cd apisix-ingress-controller > >> > > >> > 4. Build > >> > > >> > Please refer to > >> > https://apisix.apache.org/docs/ingress-controller/contribute/ > >> > > >> > The vote will be open for at least 72 hours or until the necessary > >> number > >> > of > >> > votes are reached. > >> > > >> > Please vote accordingly: > >> > > >> > [ ] +1 approve > >> > [ ] +0 no opinion > >> > [ ] -1 disapprove with the reason > >> > > >> > Thanks! > >> > > >> > >> > >> -- > >> Best regards! > >> Zeping Bai @bzp2010 > >> > > >
