> From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] > Subject: Re: [PATCH] Add --enable-pool-debug to configure > > On Mon, Jan 14, 2002 at 11:55:48AM -0800, Roy T. Fielding wrote: > > > +AC_ARG_ENABLE(pool-debug, > > > + [ --enable-pool-debug[={yes|verbose}]], > > > + [ if test -z "$enableval" -o "$enableval" = "yes"; then > > > + APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG) > > > + elif test "$enableval" = "verbose"; then > > > + APR_ADDTO(CPPFLAGS, -DAPR_POOL_DEBUG_VERBOSE) > > > + fi > > > + ]) > > > + > > > > Why not use one APR_POOL_DEBUG symbol and give it values of 0 | 1 | 2 ??? > > +1. This way we could expand or rearrange the verbosity later. > > This seems as good a time as any to get it right - going to a > numbered system seems best in the long run. -- justin
Ok, that sounds like a plan. One minor nit which would be great if we could agree on: simply defining APR_POOL_DEBUG should enable the basic debug mode. Eg. $ CPPFLAGS=-DAPR_POOL_DEBUG ./configure ... Gets you the pools code with debugging enabled $ CPPFLAGS=-DAPR_POOL_DEBUG=0 ./configure Same. $ CPPFLAGS=-DAPR_POOL_DEBUG=1 ./configure Enables debugging and verbose output. Thoughts? Sander
