Sander Striker wrote:
> 
> Ok, that sounds like a plan.
> One minor nit which would be great if we could agree on:
> simply defining APR_POOL_DEBUG should enable the basic debug
> mode.
> 

+1...

Most likely it would be best to do the mojo in apr_pools.h and adjust
apr_pools.c accordingly. For example:

   #ifdef APR_POOL_DEBUG
    #if APR_POOL_DEBUG == 2
     #define APR_POOL_DEBUG_LEVEL 2
    #elif APR_POOL_DEBUG == 1
     #define APR_POOL_DEBUG_LEVEL 1
    #else
     #define APR_POOL_DEBUG_LEVEL 0
    #endif
   #endif

and use APR_POOL_DEBUG_LEVEL in apr_pools.c otherwise you run into lots
of ugly stuff in apr_pool.c. Recall that compiling with -DAPR_POOLS_DEBUG
will not result in

        #if APR_POOLS_DEBUG == 0

being true. And you can't do stuff like

        #if APR_POOLS_DEBUG == 0 || defined(APR_POOLS_DEBUG)

since that would grab the non 0 ones as well.
    
-- 
===========================================================================
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
                   will lose both and deserve neither"

Reply via email to