Branko Äibej wrote:
If the #if was an exception WRT the BEOS symbol, then your change is fine; but you should say so (perhaps you did in another post and I missed it; sorry).

I did say so when I first posted the patch a few days ago, but I should say so in the log message. The patch is re-attached with an improved log message.


- Julian

Test whether "BEOS" is defined, not whether it is non-zero, because that
is how we test it in nearly all other places in APR.

* apr/acconfig.h
  Test whether "BEOS" is defined, not whether it is non-zero.

Index: apr/acconfig.h
===================================================================
--- apr/acconfig.h      (revision 65585)
+++ apr/acconfig.h      (working copy)
@@ -19,7 +19,7 @@
 #undef ssize_t
 
 /* switch this on if we have a BeOS version below BONE */
-#if BEOS && !HAVE_BONE_VERSION
+#if defined(BEOS) && !HAVE_BONE_VERSION
 #define BEOS_R5 1
 #else
 #define BEOS_BONE 1

Reply via email to