Greg Marr wrote:
I mostly work on Windows, and VC++ only recently added a warning for that. I've been using this style for so long that it doesn't sacrifice readability, and in fact, the var == const form looks wrong now. However, this is entirely a personal preference.
Really? It's screamed at me for 15 years. Perhaps I was running at a different warning level, though. if ((that = assign)) or if ((that = assign) != NULL) quiets the error on Windows. Dunno - same for gcc?
