On 8/23/06, Mladen Turk <[EMAIL PROTECTED]> wrote:
Take 2 for the PATCH that uses hash table instead
fixed size struct.
This cause that init and terminate functions has been
moved to the apr_initialize/terminate because of
pool needed for construction table.

Comments?

A few on the actual code:

-       if (env) {
+        if (env) {

Spurious whitespace change.

             *env = apr_malloc_dbg((dupenv + 1) * sizeof (char *),
                                   __FILE__, __LINE__ );
             memcpy((void*)*env, _environ, (dupenv + 1) * sizeof (char *));
@@ -159,6 +160,9 @@
 /* Provide to win32/thread.c */
 extern DWORD tls_apr_thread;

+/* Provide to win32/threadpriv.c */
+extern apr_hash_t *tls_apr_threadkeys;
+

If this hash is going to be non-static and shared among modules it
needs to be properly prefixed.  apr_tls_threadkeys instead of
tls_apr_threadkeys.

-garrett

Reply via email to