On 8/23/06, Mladen Turk <[EMAIL PROTECTED]> wrote:
Garrett Rooney wrote: > On 8/23/06, Mladen Turk <[EMAIL PROTECTED]> wrote: > > A few on the actual code: > >> - if (env) { >> + if (env) { >Right, its a Tab police. > > If this hash is going to be non-static and shared among modules it > needs to be properly prefixed. apr_tls_threadkeys instead of > tls_apr_threadkeys. > It is not shared except between two files inside the APR, and as such is library local variable.
That doesn't mean it shouldn't be prefixed. The prefix is there to ensure that our public symbols don't conflict with symbols defined by users of the library. If it's non-static then it should be prefixed. -garrett
