Re: [Patch]: Add basic function to APR for LDAP rebind callback support.

[Graham Leggett]

Paul J. Reder wrote:

Your changes look good to me (assuming the ldap struct does get passed in to

the cleanup). I made a few minor alterations to your patch and attached it
here. I like the simplification of automatically registering the callback
and better name space protection.

Can you try this version?



Regards,
Graham
--

Index: ldap/NWGNUmakefile
===================================================================
--- ldap/NWGNUmakefile  (revision 599173)
+++ ldap/NWGNUmakefile  (working copy)
@@ -231,6 +231,7 @@
        $(OBJDIR)/apr_ldap_init.o \
        $(OBJDIR)/apr_ldap_option.o \
        $(OBJDIR)/apr_ldap_url.o \
+       $(OBJDIR)/apr_ldap_rebind.o \
        $(EOLIST)
 
 #
Index: include/apr_ldap.h.in
===================================================================
--- include/apr_ldap.h.in       (revision 599173)
+++ include/apr_ldap.h.in       (working copy)
@@ -154,6 +154,7 @@
 #include "apr_ldap_url.h"
 #include "apr_ldap_init.h"
 #include "apr_ldap_option.h"
+#include "apr_ldap_rebind.h"
 
 /** @} */
 #endif /* APR_HAS_LDAP */

I have asked the _remove function to kill the cleanup that was registered, which should make this version safe, as well as guaranteeing that the rebind will never outlive the pool that created it.

smime.p7s
Description: S/MIME Cryptographic Signature