I addressed the comments and haven't heard back from anyone
(Bojan or others). I can't commit to APR and can't commit the
Apache portion until the APR part has been committed. I know
folks were busy with the latest APR update... Has the dust
settled?
Any takers?
Thanks,
Paul J. Reder
Bojan Smojver wrote:
Quoting "Paul J. Reder" <[EMAIL PROTECTED]>:
The patches have been updated to address the issues pointed
out below (thanks Bojan).
New contents at the old links:
http://people.apache.org/~rederpj/APR-trunk_rebind.diff
http://people.apache.org/~rederpj/Apache-trunk_rebind.diff
Cool.
Question: To what end? The xref entry isn't of any use to anyone except
in terms of a node in a list that the rebind callback can scan through.
The problem is that the rebind callback function is called from the ldap
library function and has no context related to the original request info
other than the ldap handle passed to it. The xrefs and the list they are
kept in needs to be protected to avoid concurrency issues, and having the
xref pointer doesn't help the rebind callback function since the xref
pointer can't be passed to it. Is there some reason the xref entry would
be of use to the caller that I've not thought of?
Point taken. I didn't actually look into what the patch does when I
reviewed the code.
--Bojan
--
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it. Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein
