On 08/12/2008 05:11 PM, Jeff Trawick wrote:
apr-util:
testxlate : |Line 63: expected <0>, but saw <22>
(perhaps the lack of expected charset aliases in Solaris iconv()?)
I guess these last two messages are not errors::
Failed to load driver file apr_dbd_sqlite2.so
Failed to load driver file apr_dbd_sqlite3.so
Yep. These are no errors. They simply happen on systems without sqlite
installed.
A late code review found this disturbance:
Index: memcache/apr_memcache.c
===================================================================
--- memcache/apr_memcache.c (.../1.3.2) (revision 685172)
+++ memcache/apr_memcache.c (.../1.3.3) (revision 685172)
...
static apr_status_t
mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)
{
@@ -310,7 +331,11 @@
return rv;
}
+#if APR_HAS_THREADS
+ conn = malloc(sizeof( apr_memcache_conn_t )); /* non-pool space! */
+#else
conn = apr_palloc(np, sizeof( apr_memcache_conn_t ));
+#endif
conn->p = np;
@@ -334,34 +359,31 @@
rv = conn_connect(conn);
if (rv != APR_SUCCESS) {
apr_pool_destroy(np);
+ free(conn);
That free() must be inside a check for APR_HAS_THREADS (potentially
extremely painful to diagnose, but for a minority of platforms/builds).
Thanks for pointing out. Fixed in r685262.
Regards
Rüdiger
