Re: Odd thing in apr_procattr_io_set

[William A. Rowe, Jr.]

Ruediger Pluem wrote:
> While investigating PR47355 for httpd 
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=47335)
> I came across an odd thing in apr_procattr_io_set:
> 
> 
>     if ((out != APR_NO_PIPE) && (out != APR_NO_FILE)) {
>         if ((rv = apr_file_pipe_create_ex(&attr->parent_out, &attr->child_out,
>                                           out, attr->pool)) == APR_SUCCESS)
>             rv = apr_file_inherit_unset(attr->parent_out);
>         if (rv != APR_SUCCESS)
>             return rv;
>     }
>     else if (out == APR_NO_FILE)
>         attr->child_out = &no_file;
> 
>     if ((err != APR_NO_PIPE) && (err != APR_NO_FILE)) {
>         if ((rv = apr_file_pipe_create_ex(&attr->parent_err, &attr->child_err,
>                                           err, attr->pool)) != APR_SUCCESS)
> 
> Shouldn't this be == above like in the case for the output file descriptors?

Sure looks that way.