Guenter Knauf wrote: > Bill, > [email protected] schrieb: >> Author: wrowe >> Date: Fri Dec 18 05:20:42 2009 >> New Revision: 892141 >> >> URL: http://svn.apache.org/viewvc?rev=892141&view=rev >> Log: >> Netware changes; always include netware.h/library.h for >> whatever local functions or types would be aliased, in >> a public manner, and drop very stale references to flavors >> which should not be in common use. >> >> Modified: >> apr/apr/trunk/include/apr.hnw >> apr/apr/trunk/include/arch/netware/apr_private.h >> >> Modified: apr/apr/trunk/include/arch/netware/apr_private.h >> URL: >> http://svn.apache.org/viewvc/apr/apr/trunk/include/arch/netware/apr_private.h?rev=892141&r1=892140&r2=892141&view=diff >> ============================================================================== >> --- apr/apr/trunk/include/arch/netware/apr_private.h (original) >> +++ apr/apr/trunk/include/arch/netware/apr_private.h Fri Dec 18 05:20:42 2009 >> @@ -71,19 +56,10 @@ >> #define HAVE_WRITEV 1 >> >> #define HAVE_GETPASS_R 1 >> -/* >> - * check for older NDKs which have only the getpassword() function. >> - */ >> -#include <ndkvers.h> >> -#if (CURRENT_NDK_THRESHOLD < 709060000) >> -#define getpass_r getpassword >> -#endif > can you please explain too me why you think that NetWare doesnt need this > check / define any longer, and why you removed it?
It's been far more than 1.5 years since this was added to the NDK; 2.0 will be released probably ~6 months from now, certainly not quickly. So the older getpassword isn't threadsafe, getpass_r is present, and as I understand it, only a handful of individuals actually compile (vs. use) the apr library on Netware. Supporting older architectures isn't a goal of apr 2.0, AIUI. Using the modern toolchain seems like a prerequisite. What are your thoughts? Would you like me to restore this legacy workaround? [Nothing in this refactoring is suggesting backport to 1.x].
