On 19/06/18 11:02, Yann Ylavic wrote: > Hi Jean-Frédéric, > > On Tue, Jun 19, 2018 at 10:01 AM, <jfcl...@apache.org> wrote: >> Author: jfclere >> Date: Tue Jun 19 08:01:45 2018 >> New Revision: 1833786 >> >> URL: http://svn.apache.org/viewvc?rev=1833786&view=rev >> Log: >> proposal for review. > > Usually APR backports are CTR (Commit Then Review), but it does not > prevent to propose them first ;) > I don't find the corresponding trunk commit here, though.
Trunk is quite different the missing piece in 1.6.x is in file_io/win32/buffer.c line 55 (trunk is good). > >> >> + * make sure we don't unlock mutex when we haven't locked it. >> + 1.6.x patch: http://people.apache.org/~jfclere/patch.180618.txt > (assuming this is > http://people.apache.org/~jfclere/patches/patch.180618.txt, above is > 404). > > In 1.6.x, the mutex is locked unconditionally, I don't think we can > unlock it when ->buffered only. > Don't you want the whole http://svn.apache.org/r1808457 instead? That is why I wrote in STATUS, wasn't sure what is best and my changes are minimal. If you think the whole http://svn.apache.org/r1808457 is better I will go for it. Cheers Jean-Frederic > > Regards, > Yann. >
