On 22 Mar 2019, at 15:21, yla...@apache.org wrote: > Author: ylavic > Date: Fri Mar 22 13:21:27 2019 > New Revision: 1856051 > > URL: http://svn.apache.org/viewvc?rev=1856051&view=rev > Log: > Merge r1856022 from trunk: > > Use proc mutex pthread by default when robust[_np] > > On platforms that support pshared and robust pthread mutex, this is usually > the best interprocess mutex mechanism because it's efficient, posix, not > limited and not persistent on the system when the program exits (i.e. no need > to delete it explicitely before leaving, like IPC SysV or files for instance). > > Note that on older POSIX systems pthread_mutex_{setrobust,consistent}() funcs > existed with the non-posix _np() suffix, and we consider them equivalent.
Looks like this has triggered broken builds on openwrt, would it be possible to
take a look?
locks/unix/proc_mutex.c: In function 'proc_mutex_choose_method':
locks/unix/proc_mutex.c:1494:28: error: 'mutex_proc_pthread_methods' undeclared
(first use in this function); did you mean 'mutex_posixsem_methods'?
new_mutex->meth = &mutex_proc_pthread_methods;
^~~~~~~~~~~~~~~~~~~~~~~~~~
mutex_posixsem_methods
locks/unix/proc_mutex.c:1494:28: note: each undeclared identifier is reported
only once for each function it appears in
locks/unix/proc_mutex.c:1496:27: error: 'apr_os_proc_mutex_t {aka struct
apr_os_proc_mutex_t}' has no member named 'pthread_interproc'; did you mean
'psem_interproc'?
if (ospmutex->pthread_interproc == NULL) {
^~~~~~~~~~~~~~~~~
psem_interproc
locks/unix/proc_mutex.c:1499:27: error: 'apr_os_proc_mutex_t {aka struct
apr_os_proc_mutex_t}' has no member named 'pthread_interproc'; did you mean
'psem_interproc'?
new_mutex->os.pthread_interproc = ospmutex->pthread_interproc;
^~~~~~~~~~~~~~~~~
psem_interproc
locks/unix/proc_mutex.c:1499:57: error: 'apr_os_proc_mutex_t {aka struct
apr_os_proc_mutex_t}' has no member named 'pthread_interproc'; did you mean
'psem_interproc'?
new_mutex->os.pthread_interproc = ospmutex->pthread_interproc;
^~~~~~~~~~~~~~~~~
psem_interproc
make[4]: ***
[/home/minfrin/src/openwrt/openwrt/build_dir/target-mips_24kc_musl/apr-1.7.0/build/apr_rules.mk:206:
locks/unix/proc_mutex.lo] Error 1
make[4]: Leaving directory
'/home/minfrin/src/openwrt/openwrt/build_dir/target-mips_24kc_musl/apr-1.7.0'
make[3]: ***
[/home/minfrin/src/openwrt/openwrt/build_dir/target-mips_24kc_musl/apr-1.7.0/build/apr_rules.mk:118:
all-recursive] Error 1
make[3]: Leaving directory
'/home/minfrin/src/openwrt/openwrt/build_dir/target-mips_24kc_musl/apr-1.7.0'
make[2]: *** [Makefile:80:
/home/minfrin/src/openwrt/openwrt/build_dir/target-mips_24kc_musl/apr-1.7.0/.built]
Error 2
make[2]: Leaving directory '/home/minfrin/src/openwrt/packages-minfrin/libs/apr'
time: package/feeds/packages/apr/compile#17.19#5.56#22.26
make[1]: *** [package/Makefile:113: package/feeds/packages/apr/compile] Error 2
make[1]: Leaving directory '/home/minfrin/src/openwrt/openwrt'
make: *** [/home/minfrin/src/openwrt/openwrt/include/toplevel.mk:218:
package/apr/compile] Error 2
Regards,
Graham
—
smime.p7s
Description: S/MIME cryptographic signature
