That looks like a great start. I wasn't able to easily review the code because it looks like every file differs from the trunk by at least the revision number so it was hard to identify what has actually changed. The following comments and questions are based on a functional review.
- How are the profiles linked to the project? I didn't see anything obvious in the XMI dump. - Profiles appear to be organized as a flat list, but they really need to be a hierarchy so that, for example, the Java profile can depend on the UML 1.4 profile - There needs to be a user preference setting for the default profile(s) to apply to newly created projects - Be careful about commiting stuff that you didn't intend or doesn't belong in SVN (ext directory, ArgoVersion.java, test.xmi). If test.xmi is something useful, move it to argouml-core-tests. - Find a better directory and better names for the default-*.xmi files. (I know the default* naming is used now by ArgoUML, but it's not a good match for the function it provides). - Most Tags and all Constraints from UML 1.4 Standard Elements are missing (see Appendix A of spec). - There should be an ArgoUML profile with things that are ArgoUML specific (documentation, author, version, since, etc tags from Documentation tab). - The Java profile should include things which are used during Java Reverse Engineering (src_path?, etc). Or perhaps the generic Java and ArgoUML Java stuff should be kept separate? Depends on how granular we want to get. (low proirity) - It would be useful to have the profiles visible in the Explorer view so that the user can browse their contents. Look at MagicDraw or some other tools to see how linked read-only files are displayed greyed-out to show that they can't be modified. - Rather than having to explicitly load new profiles, I think it would be better to have a search list of locations that are searched for profiles, some system defined, some user specified. - Where is the JavaBeans profile stored? I couldn't find an XMI file with a name that looked like it would contain this. - Is it possible to choose a default rendering other than "text" for a stereotype? For all stereotypes in a project? I think this is another case where a hierarchy of defaults would be useful User<-Project<-Stereotype<-Fig - The AndroMDA profile would make a good use case to look at. Have you tried it? You don't want to use the flattened version of the profile that I made, but the hierarchical version. There's a problem with the way that the standard AndroMDA profile is saved by MagicDraw, so we'd have to see if we can create our own version which doesn't have this problem, but is still hierarchical. I can help with this if you want. As I said above, it looks like a great start and I'm pleased to see progress being made on this. Tom --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
