Hi Tom, > -----Original Message----- > From: Tom Morris [mailto:[EMAIL PROTECTED] > > That sounds great. It's easier for me to review the code in place > than a description, so I only skimmed your description. The only two > things that jumped out at me were: > > 1. Rename refactoring - the old name needs to be deprecated and > forward to the new name for the transition period. I think the > Eclipse refactoring tools will give you the option of doing this in > some cases, but I'm not sure they always will. > What I meant is that ActionSetTagDefinitionType already exists in the trunk is equal to ActionSetStructuralFeatureType, but it is not in use because of that (it does not handle TagDefinitions).
> 2. String format for saving types - I didn't understand what this > refers to, but I'm sure I can figure it out after looking at the code. > The types of TagDefinitions have to be saved as a Name, i.e. it is a String. So we have to decide which format the strings will have, since it must enable a posterior finding of the actual type object (either model element or metatype). See UML 1.5 (the one I have at hand) section 3.7.1. The code has all the necessary excerpts from UML 1.5 spec. (I believe 1.4 is the same in this matter) to make it more clear. > The best way to share the code is a branch in SVN if you've got one > established or are comfortable working with branches (just send us the > name/path of the branch) or as a patch attached to an issue. An > Eclipse multi-project path set is best if you use Eclipse since I > assume that you've changed at least model and model-mdr, and perhaps > argouml as well. If you can't do a multi-project patch, use separates > patch files for each piece (argouml, model, model-mdr). If you > haven't added stubs for model-euml, I can take care of that. > I have never worked with branches but I think I can figure it out. I don't have one established though. Can you create it for me? Yes, I've changed Argo (see the section 'Changed classes' in the original post) and I've added to model-mdr (section 'required new features'). I haven't added stubs for model-euml... Sergio. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
