Hello again Alexander I suspect you should also back out your change here
Modified: trunk/src/argouml-app/build.xml Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/build.xml?view=diff&pathrev=17013&r1=17012&r2=17013 ============================================================================== --- trunk/src/argouml-app/build.xml (original) +++ trunk/src/argouml-app/build.xml 2009-04-01 10:01:28-0700 @@ -67,9 +67,12 @@ <fileset dir="../argouml-core-infra/build/"> <include name="*.jar"/> </fileset> - <fileset dir="../argouml-core-model/build/"> - <include name="*.jar"/> - </fileset> + <fileset dir="../argouml-core-model/build/"> + <include name="*.jar"/> + </fileset> + <fileset dir="../argouml-core-model-mdr/build/"> + <include name="*.jar"/> + </fileset> </path> MDR should not be in the any build path for exactly the same reason as I explained for the project settings in eclipse. The model facade decides whether to delegate this work to MDR or to eUML (eclipse). Cheers Bob. 2009/4/1 Bob Tarling <[email protected]>: > Hi Alexander > > Its clear now why you wanted to change the project settings and proves > exactly why they should be left alone. > > Your code directly access MDR classes without going through our model facade. > > The model facade serves to abstract what model repository we are > using. At the moment in the released verion of ArgoUML we are using > the MDR classes you are referencing. But there is much work out the > moment to replace these with the equivalent from eclipse for the eUML > project. > > What we don't want to do when we shift from MDR to eclipse is to go > through our entire application replacing on class with another. > > That is why all references must go through the model facade. > > e.g. where you have > > if (target instanceof TemplateParameter) { > > you should instead test with a facade method > > if (Model.getFacade().isATemplateParameter(target)) { > > I've commented out the code that breaks the build. Could you have a go > at commiting again without importing any org.omg.uml classes from MDR. > > If you're not sure exactly what methods to us just ask but see if you > can get there by youself soon. > > I also notice you are using tabs for a single indent. > > That is not according to the Sun coding codelines that we follow for for this. > > According to Sun an indent is 4 spaces.I'd recommend you change > Windows->Preferences->Jave->CodeStyle->Formatter > > Select Java Conventions [built-in] and then edit it to mkae sure Tab > Policy is Spaces only and that indent is 4 and tab size is 8. > > Please edit previous commits to fix indents. > > Cheers > > Bob. > > > 2009/4/1 Bob Tarling <[email protected]>: >> Sounds good. >> >>> 1. There is no icon for template parameter in pop-up menu (I didn't find >>> where the icon is attached) >> I think there is a mapping defined somewhere from model element names >> to some image name, I'm not sure where this is off the top of my head. >> It would seem simpler to me if we just had a set of images whose names >> already matched but that as a slight aside. >> >>> 2. In the property panel the first field (that is template parameter name) >>> is written over panel label (they both are in the first line) >> Is there a toolbar shown in the prop panel? I think I have seen the >> display looking odd in the past without that. >> >> If you can't complete fix either of the above it sounds like they're >> still close enough for first commit. If you then raise an issue for >> any outstanding work I'll be able to see what is there to help more >> directly. >> >> Bob. >> >> >> 2009/4/1 Alexander Lepekhine <[email protected]>: >>> ok, now it works. Two small issues remain: >>> >>> ------------------------------------------------------ >>> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=1507447 >>> >>> To unsubscribe from this discussion, e-mail: >>> [[email protected]]. >>> To be allowed to post to the list contact the mailing list moderator, >>> email: [[email protected]] >>> >> > ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=1510130 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
