[ 
https://issues.apache.org/jira/browse/ARIA-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901323#comment-15901323
 ] 

ASF GitHub Bot commented on ARIA-105:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r104925924
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -69,21 +73,38 @@ def __init__(self,
                      ignore_failure=None,
                      inputs=None,
                      plugin=None,
    -                 runs_on=None):
    +                 runs_on=None,
    +                 dry=False):
             """
             Creates an operation task using the name, details, node instance 
and any additional kwargs.
    -        :param name: the operation of the name.
    +
    +        :param name: the name of the operation.
             :param actor: the operation host on which this operation is 
registered.
             :param inputs: operation inputs.
             """
    -        assert isinstance(actor, (model.Node,
    -                                  model.Relationship))
    +
    +        assert isinstance(actor, (models.Node, models.Relationship))
             super(OperationTask, self).__init__()
    +
    +        if dry:
    +            from ..dry import convert_to_dry
    +            plugin, implementation, inputs = convert_to_dry(plugin, 
implementation, inputs)
    +
    +        # Coerce inputs
    +        if inputs is None:
    +            inputs = {}
    +        else:
    +            for k, v in inputs.iteritems():
    +                if not isinstance(v, models.Parameter):
    +                    inputs[k] = models.Parameter(name=k,
    +                                                 
type_name=full_type_name(v),
    --- End diff --
    
    the type here should in principle correspond to the one in template's 
operation's inputs, correct? i understand theres no validation on this at the 
moment but im asking whether theres any benefit to saving the type name of an 
arbitrary input


> Integrate new models into parser
> --------------------------------
>
>                 Key: ARIA-105
>                 URL: https://issues.apache.org/jira/browse/ARIA-105
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to