[ 
https://issues.apache.org/jira/browse/ARIA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938623#comment-15938623
 ] 

ASF GitHub Bot commented on ARIA-83:
------------------------------------

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/81#discussion_r107708205
  
    --- Diff: aria/cli/commands.py ---
    @@ -241,12 +241,9 @@ def _get_workflow(self, context, workflow_name):
                 if workflow.type.role != 'workflow':
                     raise AttributeError('policy is not a workflow: 
"{0}"'.format(workflow_name))
     
    -            try:
    -                
sys.path.append(workflow.properties['implementation'].value)
    -            except KeyError:
    -                pass
    +            
sys.path.append(os.path.dirname(str(context.presentation.location)))
    --- End diff --
    
    My previous implementation had a stupid extra `function` property which was 
just a temporary solution. Obviously it's enough to just have an 
`implementation` property. Until we handle true CSAR, I guess we can just 
pretend that artifacts are in the same directory as the main YAML.


> Store built-in YAMLs in TOSCA extension
> ---------------------------------------
>
>                 Key: ARIA-83
>                 URL: https://issues.apache.org/jira/browse/ARIA-83
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The built-in YAMLs (plugin/workflow policy definitions, built-in workflow 
> policies, execution plugin's types and policy) should sit under the TOSCA 
> extension to be easily importable.
> (This also includes first writing the execution plugin's types and policy)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to