[
https://issues.apache.org/jira/browse/ARIA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938651#comment-15938651
]
ASF GitHub Bot commented on ARIA-83:
------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/81#discussion_r107709858
--- Diff: aria/cli/commands.py ---
@@ -241,12 +241,9 @@ def _get_workflow(self, context, workflow_name):
if workflow.type.role != 'workflow':
raise AttributeError('policy is not a workflow:
"{0}"'.format(workflow_name))
- try:
-
sys.path.append(workflow.properties['implementation'].value)
- except KeyError:
- pass
+
sys.path.append(os.path.dirname(str(context.presentation.location)))
--- End diff --
I actually didn't mean the `function` part, but rather the part where we
append the directory of the main yaml rather than a separate implementation
string.
workflows code should be treated the same as operations code i.e. it comes
from plugins, at the moment we dont install it via csar so it made more sense
to me to keep it the first way but i guess for the time being it'll indeed be
more convenient to supply workflows this way - however it means that if you
install workflow code with your plugins you wont be able to run it.
> Store built-in YAMLs in TOSCA extension
> ---------------------------------------
>
> Key: ARIA-83
> URL: https://issues.apache.org/jira/browse/ARIA-83
> Project: AriaTosca
> Issue Type: Story
> Reporter: Ran Ziv
> Assignee: Tal Liron
>
> The built-in YAMLs (plugin/workflow policy definitions, built-in workflow
> policies, execution plugin's types and policy) should sit under the TOSCA
> extension to be easily importable.
> (This also includes first writing the execution plugin's types and policy)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
