[ 
https://issues.apache.org/jira/browse/ARIA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965827#comment-15965827
 ] 

ASF GitHub Bot commented on ARIA-92:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111147368
  
    --- Diff: aria/modeling/service_instance.py ---
    @@ -522,17 +524,10 @@ def properties(cls):
         __mapper_args__ = {'version_id_col': version} # Enable SQLAlchemy 
automatic version counting
     
         @property
    -    def ip(self):
    -        # TODO: totally broken
    -        if not self.host_fk:
    -            return None
    -        host_node = self.host
    -        if 'ip' in host_node.runtime_properties:  # pylint: 
disable=no-member
    -            return host_node.runtime_properties['ip']  # pylint: 
disable=no-member
    -        host_node = host_node.node_template  # pylint: disable=no-member
    -        host_ip_property = host_node.properties.get('ip')
    -        if host_ip_property:
    -            return host_ip_property.value
    +    def host_address(self):
    +        if self.host:
    --- End diff --
    
    &&? :P


> Execution plugin operations default mappings
> --------------------------------------------
>
>                 Key: ARIA-92
>                 URL: https://issues.apache.org/jira/browse/ARIA-92
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The execution plugin serves as the default plugin, i.e. if no other plugin 
> was specified, it'll be used to execute scripts in operations.
> These scripts will currently only execute locally. The execution plugin also 
> supports running scripts on remote machines (via SSH).
> One option is to have the parser recognize whether the node in question is 
> contained inside a host node, in which case the script should be executed 
> remotely (by default, yet overridable by specifying the full plugin operation 
> mapping), and if not then it should be executed locally.
> Another option is to have the user specify it using special syntax, e.g.:
> "local > script.sh" and "remote > script.sh"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to