[ 
https://issues.apache.org/jira/browse/ARIA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965863#comment-15965863
 ] 

ASF GitHub Bot commented on ARIA-92:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111152020
  
    --- Diff: aria/modeling/service_instance.py ---
    @@ -1685,12 +1725,31 @@ def inputs(cls):
         # endregion
     
         description = Column(Text)
    +    relationship_edge = Column(Boolean)
         implementation = Column(Text)
    +    configuration = Column(modeling_types.StrictDict(key_cls=basestring))
         dependencies = Column(modeling_types.StrictList(item_cls=basestring))
         executor = Column(Text)
         max_retries = Column(Integer)
         retry_interval = Column(Integer)
     
    +    def configure(self):
    +        from . import models
    +        if (self.implementation is None) or (self.interface is None):
    +            return
    +
    +        if self.plugin is None:
    +            arguments = configure_operation(self)
    --- End diff --
    
    please use `execution_plugin.instantiation.configure_operation` or so, 
there are enough `configure_operation` calls in this module as it is and it's 
easily confusing :)


> Execution plugin operations default mappings
> --------------------------------------------
>
>                 Key: ARIA-92
>                 URL: https://issues.apache.org/jira/browse/ARIA-92
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The execution plugin serves as the default plugin, i.e. if no other plugin 
> was specified, it'll be used to execute scripts in operations.
> These scripts will currently only execute locally. The execution plugin also 
> supports running scripts on remote machines (via SSH).
> One option is to have the parser recognize whether the node in question is 
> contained inside a host node, in which case the script should be executed 
> remotely (by default, yet overridable by specifying the full plugin operation 
> mapping), and if not then it should be executed locally.
> Another option is to have the user specify it using special syntax, e.g.:
> "local > script.sh" and "remote > script.sh"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to