[ 
https://issues.apache.org/jira/browse/ARIA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965951#comment-15965951
 ] 

ASF GitHub Bot commented on ARIA-92:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111165113
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py 
---
    @@ -461,8 +492,15 @@ def create_workflow_operation_template_model(context, 
service_template, policy):
         properties = policy._get_property_values(context)
         for prop_name, prop in properties.iteritems():
             if prop_name == 'implementation':
    -            model.plugin_specification, model.implementation = \
    -                parse_implementation_string(context, service_template, 
prop.value)
    +            plugin_name, model.implementation = split_prefix(prop.value)
    +            if plugin_name is not None:
    --- End diff --
    
    duplicate code, why not refactor this?


> Execution plugin operations default mappings
> --------------------------------------------
>
>                 Key: ARIA-92
>                 URL: https://issues.apache.org/jira/browse/ARIA-92
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>
> The execution plugin serves as the default plugin, i.e. if no other plugin 
> was specified, it'll be used to execute scripts in operations.
> These scripts will currently only execute locally. The execution plugin also 
> supports running scripts on remote machines (via SSH).
> One option is to have the parser recognize whether the node in question is 
> contained inside a host node, in which case the script should be executed 
> remotely (by default, yet overridable by specifying the full plugin operation 
> mapping), and if not then it should be executed locally.
> Another option is to have the user specify it using special syntax, e.g.:
> "local > script.sh" and "remote > script.sh"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to