[
https://issues.apache.org/jira/browse/ARIA-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990211#comment-15990211
]
ASF GitHub Bot commented on ARIA-155:
-------------------------------------
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/114#discussion_r114074254
--- Diff: tests/modeling/test_models.py ---
@@ -206,31 +206,26 @@ def test_service_template_model_creation(self,
empty_storage, is_valid, descript
class TestService(object):
@pytest.mark.parametrize(
- 'is_valid, name, created_at, description, inputs, permalink, '
- 'outputs, scaling_groups, updated_at',
+ 'is_valid, name, created_at, description, inputs, '
+ 'outputs, updated_at',
[
- (False, m_cls, now, 'desc', {}, 'perlnk', {}, {}, now),
- (False, 'name', m_cls, 'desc', {}, 'perlnk', {}, {}, now),
- (False, 'name', now, m_cls, {}, 'perlnk', {}, {}, now),
- (False, 'name', now, 'desc', {}, m_cls, {}, {}, now),
- (False, 'name', now, 'desc', {}, 'perlnk', m_cls, {}, now),
- (False, 'name', now, 'desc', {}, 'perlnk', {}, m_cls, now),
- (False, 'name', now, 'desc', {}, 'perlnk', {}, {}, m_cls),
-
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
- (True, None, now, 'desc', {}, 'perlnk', {}, {}, now),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
- (True, 'name', now, None, {}, 'perlnk', {}, {}, now),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
- (True, 'name', now, 'desc', {}, None, {}, {}, now),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, None, now),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, None),
- (True, 'name', now, 'desc', {}, 'perlnk', {}, {}, now),
+ (False, m_cls, now, 'desc', {}, {}, now),
+ (False, 'name', m_cls, 'desc', {}, {}, now),
+ (False, 'name', now, m_cls, {}, {}, now),
+ (False, 'name', now, 'desc', m_cls, {}, now),
+ (False, 'name', now, 'desc', {}, m_cls, now),
+ (False, 'name', now, 'desc', {}, {}, m_cls),
+
+ (True, 'name', now, 'desc', {}, {}, now),
+ (True, None, now, 'desc', {}, {}, now),
+ (True, 'name', now, None, {}, {}, now),
+ (True, 'name', now, 'desc', {}, {}, now),
+ (True, 'name', now, 'desc', {}, {}, None),
+ (True, 'name', now, 'desc', {}, {}, now),
--- End diff --
same as line 222 and 219
> Clean models from unused fields
> -------------------------------
>
> Key: ARIA-155
> URL: https://issues.apache.org/jira/browse/ARIA-155
> Project: AriaTosca
> Issue Type: Task
> Reporter: Ran Ziv
> Assignee: Ran Ziv
> Priority: Minor
>
> Some models have fields which should probably be removed (as they're no
> longer in use or haven't been put to use yet) or rename (due to
> inconsistencies).
> Suggested changes:
> Service changes module:
> - remove module entirely, until we actually implement scaling /
> service-update
> Service:
> - remove {{permalink}}
> - remove {{scaling_groups}}
> Node:
> - remove {{scaling_groups}}
> Operation:
> - rename {{max_retries}} to {{max_attempts}}
> OperationTemplate:
> - rename {{max_retries}} to {{max_attempts}}
> Execution:
> - remove {{is_system_workflow}}
> Task:
> - rename {{retry_count}} to {{attempts_count}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
