[
https://issues.apache.org/jira/browse/ARIA-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990209#comment-15990209
]
ASF GitHub Bot commented on ARIA-155:
-------------------------------------
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/114#discussion_r114074281
--- Diff: tests/modeling/test_models.py ---
@@ -549,23 +540,23 @@ def test_node_template_model_creation(self,
service_storage, is_valid, name, def
class TestNode(object):
@pytest.mark.parametrize(
- 'is_valid, name, runtime_properties, scaling_groups, state,
version',
+ 'is_valid, name, runtime_properties, state, version',
[
- (False, m_cls, {}, [], 'state', 1),
- (False, 'name', m_cls, [], 'state', 1),
- (False, 'name', {}, m_cls, 'state', 1),
- (False, 'name', {}, [], m_cls, 1),
- (False, m_cls, {}, [], 'state', m_cls),
-
- (True, 'name', {}, [], 'initial', 1),
- (True, None, {}, [], 'initial', 1),
- (True, 'name', None, [], 'initial', 1),
- (True, 'name', {}, None, 'initial', 1),
- (True, 'name', {}, [], 'initial', None),
+ (False, m_cls, {}, 'state', 1),
+ (False, 'name', m_cls, 'state', 1),
+ (False, 'name', {}, 'state', 1),
+ (False, 'name', {}, m_cls, 1),
+ (False, m_cls, {}, 'state', m_cls),
+
+ (True, 'name', {}, 'initial', 1),
+ (True, None, {}, 'initial', 1),
+ (True, 'name', None, 'initial', 1),
+ (True, 'name', {}, 'initial', 1),
--- End diff --
same as 551
> Clean models from unused fields
> -------------------------------
>
> Key: ARIA-155
> URL: https://issues.apache.org/jira/browse/ARIA-155
> Project: AriaTosca
> Issue Type: Task
> Reporter: Ran Ziv
> Assignee: Ran Ziv
> Priority: Minor
>
> Some models have fields which should probably be removed (as they're no
> longer in use or haven't been put to use yet) or rename (due to
> inconsistencies).
> Suggested changes:
> Service changes module:
> - remove module entirely, until we actually implement scaling /
> service-update
> Service:
> - remove {{permalink}}
> - remove {{scaling_groups}}
> Node:
> - remove {{scaling_groups}}
> Operation:
> - rename {{max_retries}} to {{max_attempts}}
> OperationTemplate:
> - rename {{max_retries}} to {{max_attempts}}
> Execution:
> - remove {{is_system_workflow}}
> Task:
> - rename {{retry_count}} to {{attempts_count}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
