[ 
https://issues.apache.org/jira/browse/ARIA-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001271#comment-16001271
 ] 

ASF GitHub Bot commented on ARIA-210:
-------------------------------------

GitHub user AviaE opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/128

    ARIA-210 Handle relative paths in CLI service-templates

    This was a rather simple change, mainly involving adding absolute path
    references.
    
    The problems were only in `service-templates store` and in
    `service-templates create-archive`.
    `service-templates validate` was not affected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca 
ARIA-210-handle-relative-paths-in-cli-service-templates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit 0a3ea7991d6218438318d93232f82e7d7d42d4ae
Author: Avia Efrat <a...@gigaspaces.com>
Date:   2017-05-08T14:45:23Z

    ARIA-210 Handle relative paths in CLI service-templates
    
    This was a rather simple change, mainly involving adding absolute path
    references.
    
    The problems were only in `service-templates store` and in
    `service-templates create-archive`.
    `service-templates validate` was not affected.

----


> Relative paths may cause issues in `aria service-templates` commands
> --------------------------------------------------------------------
>
>                 Key: ARIA-210
>                 URL: https://issues.apache.org/jira/browse/ARIA-210
>             Project: AriaTosca
>          Issue Type: Bug
>            Reporter: Ran Ziv
>            Assignee: Avia Efrat
>
> The CLI commands {{aria service-templates store}} and {{aria 
> service-templates create-archive}} use the {{os.path.dirname}} method to get 
> the directory of the main service-template file.
> In the former ({{store}} command) this causes errors when the user is already 
> in the directory of the main service-template file and passes the file 
> directly (e.g. {{aria service-templates store service-template.yaml 
> my-service-template}})) - It'll fail when trying to copy the 
> service-template's resources like so:
> {{cannot copy tree '': not a directory}}
> In the latter ({{create-archive}}), any relative path usage will result in an 
> error claiming the file does not exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to