[
https://issues.apache.org/jira/browse/ARIA-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001337#comment-16001337
]
ASF GitHub Bot commented on ARIA-210:
-------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/128#discussion_r115324345
--- Diff: aria/cli/csar.py ---
@@ -38,17 +38,19 @@
}
-def write(source, entry, destination, logger):
- source = os.path.expanduser(source)
- destination = os.path.expanduser(destination)
- entry_definitions = os.path.join(source, entry)
+def write(service_template_path, destination, logger):
--- End diff --
good, i like the signature better this way
> Relative paths may cause issues in `aria service-templates` commands
> --------------------------------------------------------------------
>
> Key: ARIA-210
> URL: https://issues.apache.org/jira/browse/ARIA-210
> Project: AriaTosca
> Issue Type: Bug
> Reporter: Ran Ziv
> Assignee: Avia Efrat
>
> The CLI commands {{aria service-templates store}} and {{aria
> service-templates create-archive}} use the {{os.path.dirname}} method to get
> the directory of the main service-template file.
> In the former ({{store}} command) this causes errors when the user is already
> in the directory of the main service-template file and passes the file
> directly (e.g. {{aria service-templates store service-template.yaml
> my-service-template}})) - It'll fail when trying to copy the
> service-template's resources like so:
> {{cannot copy tree '': not a directory}}
> In the latter ({{create-archive}}), any relative path usage will result in an
> error claiming the file does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
