[ 
https://issues.apache.org/jira/browse/ARIA-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004623#comment-16004623
 ] 

ASF GitHub Bot commented on ARIA-148:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r115728444
  
    --- Diff: aria/cli/commands/services.py ---
    @@ -38,6 +41,53 @@ def services():
         pass
     
     
    [email protected](name='show',
    +                  short_help='Display service information')
    [email protected]('service-name')
    [email protected]()
    [email protected]_all
    [email protected]_graph
    [email protected]_json
    [email protected]_yaml
    [email protected]_model_storage
    [email protected]_logger
    +def show(service_name, model_storage, all, graph, json, yaml, logger):
    +    """Show information for a specific service template
    +
    +    `SERVICE_NAME` is the name of the service to display information on.
    +    """
    +    logger.info('Showing service {0}...'.format(service_name))
    +    service = model_storage.service.get_by_name(service_name)
    +
    +    if json or yaml:
    +        all = True
    --- End diff --
    
    i actually didnt mean the flag but only the variables etc.,
    although now that i think of it it might also be better to change the flag, 
as it might be confusing i.e. users might think it will show all 
service-templates or so..?
    in any case what matters to me more is the variables, the flag can still be 
`all` to the user, but the "destination" of the variable (configurable in 
`aria.py`) should be renamed.


> Enhance CLI "show" commands
> ---------------------------
>
>                 Key: ARIA-148
>                 URL: https://issues.apache.org/jira/browse/ARIA-148
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>
> For {{aria service-templates show}} and {{aria services show}} add support 
> for dumping, including graphs and type hierarchies, in JSON and YAML.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to