[
https://issues.apache.org/jira/browse/ARIA-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006112#comment-16006112
]
ASF GitHub Bot commented on ARIA-148:
-------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/107#discussion_r115934648
--- Diff: aria/cli/core/aria.py ---
@@ -325,6 +339,46 @@ def __init__(self):
default=defaults.SERVICE_TEMPLATE_FILENAME,
help=helptexts.SERVICE_TEMPLATE_FILENAME)
+ self.show_full = click.option(
+ '-f',
+ '--full',
+ 'mode',
+ is_flag=True,
+ flag_value='full',
--- End diff --
I think I don't like this approach as much at the previous one.
It seems like it simplifies the code a bit but makes things somewhat more
confusing to the user - specifically the fact that only the last flag of a
given "destination" (e.g. `mode`) takes hold.
If instead you have different destinations for these flags, it'd be easier
to inform the user of misuse (even if for some reason the mutually-exclusive
mechanism is problematic to use, you can always just manually validate the
parameters in the command function itself)
> Enhance CLI "show" commands
> ---------------------------
>
> Key: ARIA-148
> URL: https://issues.apache.org/jira/browse/ARIA-148
> Project: AriaTosca
> Issue Type: Story
> Reporter: Tal Liron
> Assignee: Tal Liron
>
> For {{aria service-templates show}} and {{aria services show}} add support
> for dumping, including graphs and type hierarchies, in JSON and YAML.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
