I'm a little confused. I did this commit, but when I check out a fresh new copy of Aries trunk it doesn't appear. My new checkout only goes to r1209115... What's wrong?
Thanks, David On 1 December 2011 15:27, <[email protected]> wrote: > Author: davidb > Date: Thu Dec 1 15:27:04 2011 > New Revision: 1209121 > > URL: http://svn.apache.org/viewvc?rev=1209121&view=rev > Log: > Change double constant used in test from the famously problematic one that > was fixed in Java 1.6 24 to another constant that works with all java > versions. > > Modified: > > aries/trunk/util/util-r42/src/test/java/org/apache/aries/util/manifest/ManifestHeaderProcessorTest.java > > Modified: > aries/trunk/util/util-r42/src/test/java/org/apache/aries/util/manifest/ManifestHeaderProcessorTest.java > URL: > http://svn.apache.org/viewvc/aries/trunk/util/util-r42/src/test/java/org/apache/aries/util/manifest/ManifestHeaderProcessorTest.java?rev=1209121&r1=1209120&r2=1209121&view=diff > ============================================================================== > --- > aries/trunk/util/util-r42/src/test/java/org/apache/aries/util/manifest/ManifestHeaderProcessorTest.java > (original) > +++ > aries/trunk/util/util-r42/src/test/java/org/apache/aries/util/manifest/ManifestHeaderProcessorTest.java > Thu Dec 1 15:27:04 2011 > @@ -553,7 +553,7 @@ public class ManifestHeaderProcessorTest > String s = > "com.acme.dictionary; effective:=resolve; from:String=nl; to=de; > version:Version=3.4.0.test;somedir:=test, " + > "com.acme.dictionary; filter:=\"(&(width>=1000)(height>=1000))\", " > + > - > "com.acme.ip2location;country:List<String>=\"nl,be,fr,uk\";version:Version=1.3;long:Long=" > + Long.MAX_VALUE + ";d:Double=\"2.2250738585072012e-308\""; > + > "com.acme.ip2location;country:List<String>=\"nl,be,fr,uk\";version:Version=1.3;long:Long=" > + Long.MAX_VALUE + ";d:Double=\"3.141592653589793\""; > > List<GenericMetadata> capabilities = > ManifestHeaderProcessor.parseCapabilityString(s); > testCapabilitiesOrRequirements(capabilities); > @@ -564,7 +564,7 @@ public class ManifestHeaderProcessorTest > String s = > "com.acme.dictionary; effective:=resolve; from:String=nl; to=de; > version:Version=3.4.0.test;somedir:=test, " + > "com.acme.dictionary; filter:=\"(&(width>=1000)(height>=1000))\", " > + > - > "com.acme.ip2location;country:List<String>=\"nl,be,fr,uk\";version:Version=1.3;long:Long=" > + Long.MAX_VALUE + ";d:Double=\"2.2250738585072012e-308\""; > + > "com.acme.ip2location;country:List<String>=\"nl,be,fr,uk\";version:Version=1.3;long:Long=" > + Long.MAX_VALUE + ";d:Double=\"3.141592653589793\""; > > List<GenericMetadata> capabilities = > ManifestHeaderProcessor.parseRequirementString(s); > testCapabilitiesOrRequirements(capabilities); > @@ -617,6 +617,6 @@ public class ManifestHeaderProcessorTest > assertEquals(new Version(1, 3, 0), cap.getAttributes().get("version")); > assertEquals(Arrays.asList("nl", "be", "fr", "uk"), > cap.getAttributes().get("country")); > assertEquals(Long.MAX_VALUE, cap.getAttributes().get("long")); > - assertEquals(0, new > Double("2.2250738585072012e-308").compareTo((Double) > cap.getAttributes().get("d"))); > + assertEquals(0, new Double("3.141592653589793").compareTo((Double) > cap.getAttributes().get("d"))); > } > } > >
