[ 
https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391570#comment-15391570
 ] 

Guillaume Nodet commented on ARIES-1546:
----------------------------------------

In the first part of the patch, the bootClassLoader is always added to create a 
MultiClassLoader object.  Is it required in all cases ? The plain simple use 
case should be that the class loader loading the implementation is able to see 
all interfaces, so in those simple cases, there's no need to create any 
ClassLoader at all.  Imho, this simple use case should also work with modules, 
so if possible, i'd rather have the patch being a bit smarter and only add the 
bootClassLoader if necessary.  Also, the classLoader object can already be 
bootClassLoader, and in such case, adding it twice would not make sense.

On the reflection part, it would make sense to make the two Method fields final.

> make proxy-impl works with java9
> --------------------------------
>
>                 Key: ARIES-1546
>                 URL: https://issues.apache.org/jira/browse/ARIES-1546
>             Project: Aries
>          Issue Type: Improvement
>          Components: Proxy
>            Reporter: Freeman Fang
>         Attachments: ARIES-1546.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to