[ 
https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392069#comment-15392069
 ] 

Freeman Fang commented on ARIES-1546:
-------------------------------------

Hi Guillaume,

Thanks for looking into this patch.

The original purpose of this patch isn't build proxy impl with java9, still 
build with java8 but can run it with java9 in Karaf. Like we have proxy-impl 
dependency in Karaf, and if we build/run Karaf with java9, this patch fix issue 
we hit in Karaf with java9.

Anyway, I just did some experimental for building proxy-impl with java9, with 
some more classloader.getResourceAsStream change, I get most tests passed,  but 
still have 4 failed
{code}
  InterfaceProxyingTest.testGetProxyInstance2:122 » UnableToProxy 
java.lang.Clas...
  InterfaceProxyingTest.testHandlesObjectMethods:223 » UnableToProxy 
java.lang.C...
  WovenProxyPlusSubclassGeneratorTest.testAddingInterfacesToClass:219 » 
UnableToProxy
  WovenSubclassGeneratorTest.testAddingInterfacesToClass:200 » UnableToProxy 
jav...
{code}

And the cause are same
{code}
org.apache.aries.proxy.UnableToProxyException: java.lang.ClassFormatError: 
Absent Code attribute in method that is not native or abstract in class file 
Proxyd262d56c_3a5c_4ff8_a417_93fe3554cc36
        at java.lang.ClassLoader.defineClass1(java.base@9-ea/Native Method)
        at 
java.lang.ClassLoader.defineClass(java.base@9-ea/ClassLoader.java:942)
        at 
org.apache.aries.proxy.impl.interfaces.ProxyClassLoader.createProxyClass(ProxyClassLoader.java:160)
        at 
org.apache.aries.proxy.impl.interfaces.InterfaceProxyGenerator.getProxyInstance(InterfaceProxyGenerator.java:97)
{code}

FYI, I'm still on it and hopefully I will attach a new patch soon.

Best Regards
Freeman


> make proxy-impl works with java9
> --------------------------------
>
>                 Key: ARIES-1546
>                 URL: https://issues.apache.org/jira/browse/ARIES-1546
>             Project: Aries
>          Issue Type: Improvement
>          Components: Proxy
>            Reporter: Freeman Fang
>            Assignee: Guillaume Nodet
>         Attachments: ARIES-1546.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to