Thanks Kou. This is a good learning experience. We will continue to do better with each release
On Wed, Mar 27, 2019 at 3:57 PM Kouhei Sutou <k...@clear-code.com> wrote: > > Hi, > > > What controls do you think we can put in place to prevent the issues > > you had with RC0-2? For example, I merged a patch that affected the > > dev/release/02-source.sh script, in the future I could test that out > > (though perhaps we should develop an automated way to test these > > scripts) > > * RC0 problem: We can't build conda package on Windows: > https://github.com/apache/arrow/pull/4042 > > * This is caused by > https://github.com/apache/arrow/pull/3832 and > https://github.com/apache/arrow/pull/4024 . > > * If we rebased > https://github.com/apache/arrow/pull/4024 on master > and test it before we merge, we could notice the > problem. > > * We could notice the problem by nightly package build. > > * Conclusion: We should finish packaging changes on the > previous day of the release day. > > * RC1 problem: The above fix isn't enough. :< > https://github.com/apache/arrow/pull/4043 > > * I could notice the problem by testings all package > builds. I tested only wheel builds. > > * We could notice the problem by nightly package build. > > * Conclusion: We should finish packaging changes on the > previous day of the release day. > > * RC2 problem: I used the commit that doesn't include the > fix for the RC1 problem. :< > > * I forgot to merge the upstream master into the local > master before I create RC. It's a human error... > > > Thanks, > -- > kou >
