+1 (binding) Thanks Kou for adding the missing signatures.
* I was able to verify the binaries after the signature fix. The Linux package tests are very nice! * I ran the following source verifications (on linux except where noted) * C++ (Ubuntu 19.04 and Windows, with patch https://github.com/apache/arrow/pull/4770) * Python (UB19.04 / Windows) * Java * JS * Ruby * GLib * Go * Rust * Integration tests with Flight (with minor patch https://github.com/apache/arrow/pull/4775) I only had trouble with C#, and it may be environment specific. On Mon, Jul 1, 2019 at 4:32 PM Sutou Kouhei <k...@clear-code.com> wrote: > > Hi, > > > but it failed with > > > > https://gist.github.com/wesm/711ae3d66c942db293dba55ff237871a > > Thanks for catching this. > I failed to upload some files. I uploaded missing files. > > I confirmed that there are no missing files with the > following Ruby script: > > -- > #!/usr/bin/env ruby > > require "open-uri" > require "json" > require "English" > > ["debian", "ubuntu", "centos", "python"].each do |target| > json_path = "/tmp/#{target}-file-list.json" > unless File.exist?(json_path) > > open("https://bintray.com/api/v1/packages/apache/arrow/#{target}-rc/versions/0.14.0-rc0/files";) > do |input| > File.open(json_path, "w") do |json| > IO.copy_stream(input, json) > end > end > end > > source_paths = [] > asc_paths = [] > sha512_paths = [] > JSON.parse(File.read(json_path)).each do |entry| > path = entry["path"] > case path > when /\.asc\z/ > asc_paths << $PREMATCH > when /\.sha512\z/ > sha512_paths << $PREMATCH > else > source_paths << path > end > end > pp([:no_asc, source_paths - asc_paths]) > pp([:no_source_for_asc, asc_paths - source_paths]) > pp([:no_sha512, source_paths - sha512_paths]) > pp([:no_source_for_sha512, sha512_paths - source_paths]) > end > -- > > But this is a bit strange. Download file list is read from > Bintray (*). So I think that our verification script doesn't > try downloading nonexistent files... > > (*) > https://bintray.com/api/v1/packages/apache/arrow/debian-rc/versions/0.14.0-rc0/files > > > I'm going to work on verifying more components. C# is failing with > > > > https://gist.github.com/wesm/985146df6944a1aade331c4bd1519f1f > > I couldn't reproduce this on my environment. > I'll try this with clean environment. > > Note that we can try only C# verification with the following > command line: > > TEST_DEFAULT=0 TEST_SOURCE=1 TEST_CSHARP=1 > dev/release/verify-release-candidate.sh source 0.14.0 0 > > > Seems like we might need to find an > > artifact staging solution that is not Bintray if API rate limits are > > going to be a problem. > > I don't get response yet from https://bintray.com/apache > organization. I'll open an issue on INFRA JIRA. > > > Thanks, > -- > kou > > In <cajpuwmbtuzdqmtr5f1ukzjfzg7t9xv0qblev3ulngoy10do...@mail.gmail.com> > "Re: [VOTE] Release Apache Arrow 0.14.0 - RC0" on Mon, 1 Jul 2019 11:48:50 > -0500, > Wes McKinney <wesmck...@gmail.com> wrote: > > > hi Antoine, I'm not sure the origin of the conda.sh failure, have you > > tried removing any bashrc stuff related to the Anaconda distribution > > that you develop against? > > > > With the following patch I'm able to run the binary verification > > > > https://github.com/apache/arrow/pull/4768 > > > > but it failed with > > > > https://gist.github.com/wesm/711ae3d66c942db293dba55ff237871a > > > > Indeed a sig is missing from bintray. I was able to get the parallel > > build to run on my machine (but it failed when I piped stdin/stdout to > > a file) but I also found a bad sig > > > > https://gist.github.com/wesm/2404d55e087cc3982d93e53c83df95d5 > > > > I'm going to work on verifying more components. C# is failing with > > > > https://gist.github.com/wesm/985146df6944a1aade331c4bd1519f1f > > > > but I don't think that should block the release (it would be nice if > > it passed though) > > > > I'm going to work on the Windows verification script and see if I can > > add Flight support to it > > > > All in all appears that an RC1 may be warranted unless the signature > > issues can be remedied in RC0. Seems like we might need to find an > > artifact staging solution that is not Bintray if API rate limits are > > going to be a problem. > > > > - Wes > > > > On Mon, Jul 1, 2019 at 3:48 AM Antoine Pitrou <anto...@python.org> wrote: > >> > >> > >> On Ubuntu 18.04: > >> > >> - failed to verify binaries > >> > >> """ > >> + echo 'Failed to verify release candidate. See /tmp/arrow-0.14.0.gucvU > >> for details.' > >> Failed to verify release candidate. See /tmp/arrow-0.14.0.gucvU for > >> details. > >> """ > >> > >> There's no details in /tmp/arrow-0.14.0.gucvU. The script left a lot of > >> zombie curl processes running... > >> > >> - failed to verify sources > >> > >> """ > >> + export PATH > >> /tmp/arrow-0.14.0.yum2X/apache-arrow-0.14.0/test-miniconda/etc/profile.d/conda.sh: > >> line 55: PS1: unbound variable > >> + ask_conda= > >> + return 1 > >> + cleanup > >> + '[' no = yes ']' > >> + echo 'Failed to verify release candidate. See /tmp/arrow-0.14.0.yum2X > >> for details.' > >> Failed to verify release candidate. See /tmp/arrow-0.14.0.yum2X for > >> details. > >> """ > >> > >> There's no details in /tmp/arrow-0.14.0.yum2X > >> > >> Regards > >> > >> Antoine. > >> > >> > >> > >> > >> > >> Le 01/07/2019 à 07:32, Sutou Kouhei a écrit : > >> > Hi, > >> > > >> > I would like to propose the following release candidate (RC0) of Apache > >> > Arrow version 0.14.0. This is a release consiting of 618 > >> > resolved JIRA issues[1]. > >> > > >> > This release candidate is based on commit: > >> > a591d76ad9a657110368aa422bb00f4010cb6b6e [2] > >> > > >> > The source release rc0 is hosted at [3]. > >> > The binary artifacts are hosted at [4][5][6][7]. > >> > The changelog is located at [8]. > >> > > >> > Please download, verify checksums and signatures, run the unit tests, > >> > and vote on the release. See [9] for how to validate a release candidate. > >> > > >> > NOTE: You must use verify-release-candidate.sh at master. > >> > I've fixed some problems after apache-arrow-0.14.0 tag. > >> > C#'s "sourcelink test" is fragile. (Network related problem?) > >> > It may be better that we add retry logic to "sourcelink test". > >> > > >> > The vote will be open for at least 72 hours. > >> > > >> > [ ] +1 Release this as Apache Arrow 0.14.0 > >> > [ ] +0 > >> > [ ] -1 Do not release this as Apache Arrow 0.14.0 because... > >> > > >> > [1]: > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.14.0 > >> > [2]: > >> > https://github.com/apache/arrow/tree/a591d76ad9a657110368aa422bb00f4010cb6b6e > >> > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.14.0-rc0 > >> > [4]: https://bintray.com/apache/arrow/centos-rc/0.14.0-rc0 > >> > [5]: https://bintray.com/apache/arrow/debian-rc/0.14.0-rc0 > >> > [6]: https://bintray.com/apache/arrow/python-rc/0.14.0-rc0 > >> > [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.14.0-rc0 > >> > [8]: > >> > https://github.com/apache/arrow/blob/a591d76ad9a657110368aa422bb00f4010cb6b6e/CHANGELOG.md > >> > [9]: > >> > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > >> > > >> > > >> > Thanks, > >> > -- > >> > kou > >> >
