On Wed, Jul 3, 2019 at 7:06 AM Wes McKinney <wesmck...@gmail.com> wrote:
> For the record, because Flight is so new and isn't being tested by very > many contributors in their environments, I would expect a lot of problems > and don't think they pose an issue for releasing. Let's open follow up > JIRAs > done, ARROW-5829 > > On Tue, Jul 2, 2019, 8:34 PM Wes McKinney <wesmck...@gmail.com> wrote: > > > @Ravindra, could you clarify what point #2 means? > > > > On Tue, Jul 2, 2019, 8:29 PM Sutou Kouhei <k...@clear-code.com> wrote: > > > >> Hi, > >> > >> Thanks for your report. > >> > >> Adding -DProtobuf_SOURCE=BUNDLED CMake option is workaround. > >> I don't think that this is a critical problem for this RC. > >> > >> We will be able to avoid this problem automatically by the > >> following patch in 1.0.0: > >> https://github.com/apache/arrow/pull/4785 > >> > >> > >> Thanks, > >> -- > >> kou > >> > >> In <cahnzt+3khftnsnrkvydr8bqggx8whocjfv-b48rp2oyrhss...@mail.gmail.com> > >> "Re: [VOTE] Release Apache Arrow 0.14.0 - RC0" on Wed, 3 Jul 2019 > >> 10:01:21 +0900, > >> Kenta Murata <m...@mrkn.jp> wrote: > >> > >> > I tried on Ubuntu Bionic, and got the build errors on grpc_ep (version > >> > 1.20.0). The error log will be shown the last of this mail. > >> > The errors are (1) absence of php_generator.h header file, and (2) the > >> > absence of has_ruby_package function in google::protobuf::FileOptions > >> > class. > >> > PHP support was introduced at the version 3.3.0. The has_ruby_package > >> > function was added at the version 3.6.0. > >> > So the minimum version of protobuf should be 3.6.0 for building grpc > >> > version 1.20.0. > >> > > >> > The error log I got is below: > >> > > >> > > >> > /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/php_generator.cc:21:10: > >> > fatal error: google/protobuf/compiler/php/php_generator.h: No such > >> > file or directory > >> > #include <google/protobuf/compiler/php/php_generator.h> > >> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > compilation terminated. > >> > make[5]: *** > >> [CMakeFiles/grpc_plugin_support.dir/src/compiler/php_generator.cc.o] > >> > Error 1 > >> > make[5]: *** Waiting for unfinished jobs.... > >> > > >> > /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc: > >> > In function ‘grpc::string grpc_ruby_generator::GetServices(const > >> > FileDescriptor*)’: > >> > > >> > /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc:165:25: > >> > error: ‘const class google::protobuf::FileOptions’ has no member named > >> > ‘has_ruby_package’; did you mean ‘has_java_package’? > >> > if (file->options().has_ruby_package()) { > >> > ^~~~~~~~~~~~~~~~ > >> > has_java_package > >> > > >> > /tmp/arrow-0.14.0.dJDu3/apache-arrow-0.14.0/cpp/build/grpc_ep-prefix/src/grpc_ep/src/compiler/ruby_generator.cc:166:38: > >> > error: ‘const class google::protobuf::FileOptions’ has no member named > >> > ‘ruby_package’; did you mean ‘java_package’? > >> > package_name = file->options().ruby_package(); > >> > ^~~~~~~~~~~~ > >> > java_package > >> > make[5]: *** > >> [CMakeFiles/grpc_plugin_support.dir/src/compiler/ruby_generator.cc.o] > >> > Error 1 > >> > make[4]: *** [CMakeFiles/grpc_plugin_support.dir/all] Error 2 > >> > make[4]: *** Waiting for unfinished jobs.... > >> > make[3]: *** [all] Error 2 > >> > > >> > > >> > Regards, > >> > Kenta Murata > >> > > >> > 2019年7月3日(水) 3:00 Yosuke Shiro <yosuke.shiro...@gmail.com>: > >> >> > >> >> Ran dev/release/verify-release-candidate.sh source 0.14.0 0 on macOS > >> Mojave. > >> >> I got the following error, but it may be specific to my environment. > >> >> > >> >> """ > >> >> [ERROR] Failed to execute goal > >> pl.project13.maven:git-commit-id-plugin:2.2.2:revision (for-jars) on > >> project arrow-java-root: Could not complete Mojo execution...: Error: > Could > >> not get HEAD Ref, are you sure you have set the dotGitDirectory > property of > >> this plugin to a valid path? -> [Help 1] > >> >> [ERROR] > >> >> [ERROR] To see the full stack trace of the errors, re-run Maven with > >> the -e switch. > >> >> [ERROR] Re-run Maven using the -X switch to enable full debug > logging. > >> >> [ERROR] > >> >> [ERROR] For more information about the errors and possible solutions, > >> please read the following articles: > >> >> [ERROR] [Help 1] > >> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > >> >> + cleanup > >> >> + '[' no = yes ']' > >> >> + echo 'Failed to verify release candidate. See > >> > /var/folders/8t/lw8gghw13hscdt7rr9j8kqnm0000gn/T/arrow-0.14.0.XXXXX.1bxYZ8hL > >> for details.' > >> >> Failed to verify release candidate. See > >> > /var/folders/8t/lw8gghw13hscdt7rr9j8kqnm0000gn/T/arrow-0.14.0.XXXXX.1bxYZ8hL > >> for details. > >> >> “"" > >> >> > >> >> """ > >> >> $ java --version > >> >> openjdk 11.0.2 2019-01-15 > >> >> OpenJDK Runtime Environment 18.9 (build 11.0.2+9) > >> >> OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode) > >> >> “"" > >> >> > >> >> """ > >> >> $ mvn --version > >> >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > >> 2018-10-25T03:41:47+09:00) > >> >> Maven home: /usr/local/Cellar/maven/3.6.0/libexec > >> >> Java version: 11.0.2, vendor: Oracle Corporation, runtime: > >> /Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home > >> >> Default locale: en_JP, platform encoding: UTF-8 > >> >> OS name: "mac os x", version: "10.14.4", arch: "x86_64", family: > "mac" > >> >> “"" > >> >> > >> >> C# verification ran fine to me. > >> >> > >> >> > >> >> > On Jul 2, 2019, at 18:57, Antoine Pitrou <anto...@python.org> > wrote: > >> >> > > >> >> > > >> >> > +1 for this RC0 anyway (binding). > >> >> > > >> >> > > >> >> > Le 02/07/2019 à 11:36, Antoine Pitrou a écrit : > >> >> >> > >> >> >> I tried again (Ubuntu 18.04): > >> >> >> > >> >> >> * binaries verification succeeded > >> >> >> > >> >> >> * source verification failed in gRPC configure step: > >> >> >> > >> >> >> CMake Error at cmake/cares.cmake:38 (find_package): > >> >> >> Could not find a package configuration file provided by "c-ares" > >> with any > >> >> >> of the following names: > >> >> >> > >> >> >> c-aresConfig.cmake > >> >> >> c-ares-config.cmake > >> >> >> > >> >> >> Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or > set > >> >> >> "c-ares_DIR" to a directory containing one of the above files. > If > >> "c-ares" > >> >> >> provides a separate development package or SDK, be sure it has > been > >> >> >> installed. > >> >> >> Call Stack (most recent call first): > >> >> >> CMakeLists.txt:139 (include) > >> >> >> > >> >> >> > >> >> >> Problem is, Ubuntu's c-ares does not provide any CMake files: > >> >> >> > >> >> >> $ dpkg -L libc-ares-dev > >> >> >> /. > >> >> >> /usr > >> >> >> /usr/include > >> >> >> /usr/include/ares.h > >> >> >> /usr/include/ares_build.h > >> >> >> /usr/include/ares_dns.h > >> >> >> /usr/include/ares_rules.h > >> >> >> /usr/include/ares_version.h > >> >> >> /usr/lib > >> >> >> /usr/lib/x86_64-linux-gnu > >> >> >> /usr/lib/x86_64-linux-gnu/libcares.a > >> >> >> /usr/lib/x86_64-linux-gnu/pkgconfig > >> >> >> /usr/lib/x86_64-linux-gnu/pkgconfig/libcares.pc > >> >> >> /usr/share > >> >> >> /usr/share/doc > >> >> >> /usr/share/doc/libc-ares-dev > >> >> >> /usr/share/doc/libc-ares-dev/NEWS.gz > >> >> >> /usr/share/doc/libc-ares-dev/README.cares > >> >> >> /usr/share/doc/libc-ares-dev/README.md > >> >> >> /usr/share/doc/libc-ares-dev/copyright > >> >> >> /usr/share/man > >> >> >> /usr/share/man/man3 > >> >> >> [ snip man pages ] > >> >> >> /usr/lib/x86_64-linux-gnu/libcares.so > >> >> >> > >> >> >> > >> >> >> Regards > >> >> >> > >> >> >> Antoine. > >> >> >> > >> >> > >> > > >> > > >> > -- > >> > Kenta Murata > >> > OpenPGP FP = 1D69 ADDE 081C 9CC2 2E54 98C1 CEFE 8AFB 6081 B062 > >> > > >> > 本を書きました!! > >> > 『Ruby 逆引きレシピ』 http://www.amazon.co.jp/dp/4798119881/mrkn-22 > >> > > >> > E-mail: m...@mrkn.jp > >> > twitter: http://twitter.com/mrkn/ > >> > blog: http://d.hatena.ne.jp/mrkn/ > >> > > > -- Thanks and regards, Ravindra.