> > I'm quite skeptical about this. My experience is that many people have a > very subjective idea of what is critical or not, and the categorization > ends up not very informative.
Antoine, skeptical about the definition of "Critical Fix"? Or something else? On "Critical Fix", I tried to make the definition provided not very ambiguous, but the PR is open for feedback. Keep in mind, I am planning on grooming these labels once every release, and including them in the generation of the changes notes. So any drift in the definition will be corrected before the final list of breaking changes and critical fixes are published. But understandable if you are skeptical. After the 12.0.0 release we should revisit, and if we don't find one or both of these labels useful we can drop them out of use. On Sat, Jan 14, 2023 at 6:15 AM Antoine Pitrou <anto...@python.org> wrote: > > I'm quite skeptical about this. My experience is that many people have a > very subjective idea of what is critical or not, and the categorization > ends up not very informative. > > Regards > > Antoine. > > > Le 13/01/2023 à 23:53, Will Jones a écrit : > > Following up: I have created a PR adding the definition [1]. While > > writing this, I ended up feeling that it made sense to keep separate > labels > > for "Critical Fix" and "Priority: Critical". > > > > [1] https://github.com/apache/arrow/pull/33660 > > > > On Sat, Jan 7, 2023 at 2:54 AM Rok Mihevc <rok.mih...@gmail.com> wrote: > > > >>> > >>> I replied in the GitHub thread [1], but will say that I am +1 on > >> Priority: > >>> Blocker and Priority: Critical. Though I wonder if we could use > "Critical > >>> Fix" in place of "Priority: Critical"? Unless we have two different > >>> definitions. As is, the names are similar enough that it could be > >>> confusing. Perhaps I can draft a full definition of "Critical Fix", and > >>> then we can discuss based on that? (I assume at the very least that > >>> Priority Critical never refers to features, right?) > >>> > >>> [1] https://github.com/apache/arrow/issues/14593 > >>> > >> > >> Agreed on the Priority: Blocker and Priority: Critical. > >> A shared definition would indeed be useful! I think best place to put it > >> would be in the issue creation interface [2]. > >> > >> [2] > >> > >> > https://github.com/apache/arrow/issues/new?assignees=&labels=Type%3A+bug&template=bug_report.yaml > >> > >> Rok > >> > > >
