-1 (non-binding)

Thanks Andrew for preparing the release.

The ASF license header in src/client/s3.rs is missing its
first line:

// Licensed to the Apache Software Foundation (ASF) under one

The file starts with "// or more contributor license
agreements..." instead. This is present in both the source
archive and v0.14.2-rc1.

Could we restore the complete header and cut a new RC?

Otherwise, SHA-256, SHA-512, the signature, and the complete
source comparison against the tag passed. On Linux x86_64,
cargo build, cargo test --all --all-features, and
cargo publish --dry-run all passed.

Cloud-backend integration tests were not exercised.

Thanks,
Xuanwo

Reply via email to