Ian Maxon has posted comments on this change. Change subject: Introducing data replication API to LSM indexes ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Cool! https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IIOReplicationManager.java File hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IIOReplicationManager.java: Line 25: public boolean isReplicationEnable(); Nit- name should be plural https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java File hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java: Line 955: Is it intentional that here we are seemingly only replicating the bloom filter?... -- To view, visit https://asterix-gerrit.ics.uci.edu/322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80565fc9d74e30440d2df5917911904ba8f33c25 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
