abdullah alamoudi has posted comments on this change. Change subject: Introducing data replication API to LSM indexes ......................................................................
Patch Set 2: (3 comments) Just a few minor comments. https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java: Line 889: This type of indexes, have three components 2 Btrees (1 main and 1 buddy) 1 Bloom filter https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java File hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java: Line 955: > Is it intentional that here we are seemingly only replicating the bloom fil @Ian We are not only replicating the bloom filter. This is just another case of "false comment" @Murtadha, Please, remove the comments below https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/buffercache/IBufferCache.java File hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/buffercache/IBufferCache.java: Line 55: If all BufferCaches don't do any replication, why are the methods below introduced? Did I miss a case where they return true when isReplicationEnabled() is called? -- To view, visit https://asterix-gerrit.ics.uci.edu/322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80565fc9d74e30440d2df5917911904ba8f33c25 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
