Till Westmann has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 7:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/344/7/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 77:         DatasetInfo dsInfo = 
datasetInfos.get(getDIDfromResourceName(resourceName));
Would it make sense to just determine the datasetID and the resourceID here and 
to then call the other getIndexMethod?


https://asterix-gerrit.ics.uci.edu/#/c/344/7/asterix-transactions/pom.xml
File asterix-transactions/pom.xml:

Line 120:       </dependencies>
> For using their Cache class in PersistentLocalResourceRepository.
Ah, yes, missed that. Thanks!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Young-Seok Kim <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to