Till Westmann has posted comments on this change. Change subject: Allow lazy loading for persistent local resources ......................................................................
Patch Set 7: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/344/7/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 77: DatasetInfo dsInfo = datasetInfos.get(getDIDfromResourceName(resourceName)); > Yes, it would. It will just cause an extra call to getResourceIDfromResourc Depends on how often we call this. But as this is in the DatasetLifecycleManager I think that we don't call it too often, and so reducing the redundancy in the code would be worth it. -- To view, visit https://asterix-gerrit.ics.uci.edu/344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
