----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60722/#review179997 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java Lines 663 (patched) <https://reviews.apache.org/r/60722/#comment254982> Consider the following updates: - move guidsInSink to ZipSink.guids - update ZipSink.add() methods to populate ZipSink.guids - add method ZipSink.hasEntity(String guid) - replace context.guidsInSink.contains(guid) with context.sink.hasEntity(guid) - Madhan Neethiraj On July 8, 2017, 12:12 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60722/ > ----------------------------------------------------------- > > (Updated July 8, 2017, 12:12 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1919 > https://issues.apache.org/jira/browse/ATLAS-1919 > > > Repository: atlas > > > Description > ------- > > **Analysis** > The connected _fetchType_ in Export API had a potential for attempting to > save same entity twice. > > **Fix** > The entities saved to the _ZipSink_ are now maintained in a separate set. > Before attempting to save to _ZipSink_ existence check is performed. If > passed, save is prevented, else entity is saved to _ZipSink_. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 3538cfd7 > > > Diff: https://reviews.apache.org/r/60722/diff/1/ > > > Testing > ------- > > **Unit tests** > - Executed existing unit tests. > > **Functional tests** > - Executed standard set of tests. > > > Thanks, > > Ashutosh Mestry > >
