-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60722/
-----------------------------------------------------------
(Updated July 10, 2017, 3:59 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Updates include:
- Refactoring based on review comments.
- Updated Unit tests.
Bugs: ATLAS-1919
https://issues.apache.org/jira/browse/ATLAS-1919
Repository: atlas
Description
-------
**Analysis**
The connected _fetchType_ in Export API had a potential for attempting to save
same entity twice.
**Fix**
The entities saved to the _ZipSink_ are now maintained in a separate set.
Before attempting to save to _ZipSink_ existence check is performed. If passed,
save is prevented, else entity is saved to _ZipSink_.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
3538cfd7
repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java
4bb04da9
repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java
635caf7f
Diff: https://reviews.apache.org/r/60722/diff/2/
Changes: https://reviews.apache.org/r/60722/diff/1-2/
Testing
-------
**Unit tests**
- Executed existing unit tests.
**Functional tests**
- Executed standard set of tests.
Thanks,
Ashutosh Mestry