> On July 9, 2017, 5:13 p.m., Apoorv Naik wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/GlossaryOMASREST.java
> > Lines 702 (patched)
> > <https://reviews.apache.org/r/60681/diff/3/?file=1772156#file1772156line702>
> >
> >     Might need to revisit this since HTTP spec allows body with DELETE 
> > request but the server is expected to ignore the body. (I might be wrong 
> > too)

Hi Appoorv - thanks for your feedback. For this method it only uses the url and 
a body - have I missed something?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60681/#review179998
-----------------------------------------------------------


On July 10, 2017, 9:31 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60681/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 9:31 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is stub code to generate some Glossary OMAS REST interfaces. 
> 
> It does not include : 
> - search
> - finding all assets
> - lineage
> 
> This patch is not to be committed at this time- it is for review purposes 
> only.
> 
> 
> Diffs
> -----
> 
>   glossaryomas/pom.xml PRE-CREATION 
>   glossaryomas/src/main/java/org/apache/atlas/model/GlossaryOMASCategory.java 
> PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/GlossaryOMASGraphEdgeDirection.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/GlossaryOMASPermission.java 
> PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/AtlasGlossaryGraph.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/AtlasGlossaryGraphEdge.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/AtlasGlossaryGraphNode.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/AtlasGlossaryTreeElement.java
>  PRE-CREATION 
>   glossaryomas/src/main/java/org/apache/atlas/model/instance/Relatable.java 
> PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/category/AtlasGlossaryCategory.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/glossary/Anchor.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/glossary/AtlasGlossary.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/AtlasGlossaryTerm.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/ExternalGlossaryLink.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/Antonym.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/ISA.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/PreferedTerm.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/RelatedTerm.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/RelatedTerms.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/ReplacementTerm.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/Synonym.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/Translation.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/RelatedTerms/ValidValue.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/SemanticAssignment/SemanticAssignment.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/TermRelationshipStatus.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/contexts/Context.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/spineObjects/SpineObjects.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/spineObjects/TermHASARelationship.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/spineObjects/TermISATYPEOFRelationship.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/spineObjects/TermSpineRelationship.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/spineObjects/TermTYPEDBYRelationship.java
>  PRE-CREATION 
>   
> glossaryomas/src/main/java/org/apache/atlas/model/instance/term/termCategorization/TermCategorization.java
>  PRE-CREATION 
>   omas/pom.xml PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/exception/AtlasOMASBaseException.java 
> PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/exception/AtlasOMASErrorCode.java 
> PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/model/EmbeddedMedia.java PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/model/MediaUsage.java PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/model/PList.java PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/model/SearchFilter.java PRE-CREATION 
>   omas/src/main/java/org/apache/atlas/model/instance/AtlasOMASEntity.java 
> PRE-CREATION 
>   pom.xml ebc07e21d2d721910f1aae7069305845284a8c21 
>   webapp/pom.xml 465d2a5498376a2517dc1b01f970734c452c504d 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryOMASREST.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60681/diff/4/
> 
> 
> Testing
> -------
> 
> generated the swagger by running mvn clean install -DskipTests 
> -DskipEnunciate=false. 
> the output is in file:///<<GIT_HOME>>/webapp/target/api/v2/apidocs/index.html
> where <<GIT_HOME>> is where you ran the Maven build.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Reply via email to